Fix bit numbers in comment for the example input reading routine#119
Merged
ISSOtm merged 1 commit intogbdev:masterfrom Feb 26, 2025
Merged
Fix bit numbers in comment for the example input reading routine#119ISSOtm merged 1 commit intogbdev:masterfrom
ISSOtm merged 1 commit intogbdev:masterfrom
Conversation
It looks like maybe the comment was copied from the one above for reading the buttons. If so, the order of the parts were swapped but not the bit numbers.
ISSOtm
suggested changes
Feb 26, 2025
Member
ISSOtm
left a comment
There was a problem hiding this comment.
I think both readings make sense, one being before the swap and the other after it. I think giving the comment its own line (so, with this change, after the instruction) would clear up any confusion.
Contributor
Author
All of the other inline comments in the routine describe the state after the instruction has been applied. I think it would be a bit strange to interpret this one comment as the state before the instruction. It really looks like just a copy-and-paste mistake to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like maybe the comment was copied from the one above for reading the buttons. If so, the order of the parts were swapped but not the bit numbers.