Skip to content

Comments

fixed duration read and write benchmarks#762

Open
jasha26 wants to merge 2 commits intofsspec:mainfrom
ankitaluthra1:feat/jasha-perf-benchmarks-fixes
Open

fixed duration read and write benchmarks#762
jasha26 wants to merge 2 commits intofsspec:mainfrom
ankitaluthra1:feat/jasha-perf-benchmarks-fixes

Conversation

@jasha26
Copy link
Contributor

@jasha26 jasha26 commented Feb 18, 2026

This Pull Request transitions our performance benchmarking suite from iteration-based to fixed-duration execution. By standardizing benchmarks to run for a set period (e.g., 60 seconds), we ensure that performance metrics are statistically significant and resilient to transient network fluctuations, providing a more reliable baseline for GCS operations.

Key Changes

  • Fixed-Duration Logic: Refactored read and write benchmark scripts to execute loops based on a duration parameter rather than a fixed number of operations.
  • Throughput Calculation: Updated reporting modules to calculate MiB/sec and IOPS based on the actual elapsed time and total data transferred.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.93%. Comparing base (d74b647) to head (a0359a6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
gcsfs/tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   75.39%   75.93%   +0.54%     
==========================================
  Files          19       19              
  Lines        2865     2888      +23     
==========================================
+ Hits         2160     2193      +33     
+ Misses        705      695      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasha26
Copy link
Contributor Author

jasha26 commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review. ✅ Project coverage is 75.79%. Comparing base (d74b647) to head (a0359a6). ⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
gcsfs/tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files

@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   75.39%   75.79%   +0.40%     
==========================================
  Files          19       19              
  Lines        2865     2888      +23     
==========================================
+ Hits         2160     2189      +29     
+ Misses        705      699       -6     

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

Since the flagged file is conftest.py, i am ignoring this finding.

@jasha26 jasha26 closed this Feb 19, 2026
@jasha26 jasha26 reopened this Feb 19, 2026
@ankitaluthra1
Copy link
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants