[pigeon] Modernize Obj-C generation headers #10857
Merged
+40
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request modernizes the Objective-C code generation by replacing old-style framework imports with module imports (@import) and removes the now-obsolete ARC check. The changes are correctly implemented in the generator, and the generated files are updated accordingly. A new test has been added to verify the use of module imports, which is a great addition. My only concern is a version mismatch between pubspec.yaml and lib/src/generator_tools.dart, which I've detailed in a specific comment.
linchen00
pushed a commit
to linchen00/packages
that referenced
this pull request
Jan 23, 2026
Replaces the older style of framework imports (`#import <Foo/Foo.h>`) with the newer module style (`@import Foo;`). Also opportunistically removes the ARC check; it's wildly unlikely that anyone writing a new plugin would disable ARC. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. (cherry picked from commit d0c7d1f)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2026
flutter/packages@9010299...5af5f50 2026-01-23 6655696+guidezpl@users.noreply.github.com Update Google Fonts to v8.0.0 with new and removed fonts (flutter/packages#10785) 2026-01-22 stuartmorgan@google.com [pigeon] Modernize Obj-C generation headers (flutter/packages#10857) 2026-01-22 47866232+chunhtai@users.noreply.github.com Fixes sync_release_pr workflow yaml formatting (flutter/packages#10855) 2026-01-22 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 6 (flutter/packages#10752) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the older style of framework imports (
#import <Foo/Foo.h>) with the newer module style (@import Foo;).Also opportunistically removes the ARC check; it's wildly unlikely that anyone writing a new plugin would disable ARC.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3