Skip to content

Conversation

@itsjustkevin
Copy link
Contributor

Flutter beta 2.12.0-4.2.pre Framework

Scheduled Cherrypicks

  • None

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@XilaiZhang
Copy link
Contributor

I think its the same failure as in #100731, should be good

@itsjustkevin itsjustkevin merged commit 5c931b7 into flutter:flutter-2.12-candidate.4 Mar 29, 2022
@itsjustkevin itsjustkevin deleted the cherrypicks-flutter-2.12-candidate.4 branch March 29, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants