Test PR to see whether this is your process. #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the changes. I hit the pre-processor.md page when trying to get <?if?> to work (which is another story). I can happily pull together a PR if your project works like this. This change is more of a "test the water" to see if you would want this. So please close this PR with either "sure have at it" or "sorry, not the way we do things". Either way I'll not be offended. (and yes, I am working on an opensource project and FWIW I believe that Opensource only flourishes when people submit patches).
Member
|
Sure but if it's related to WiX doc, you should start by opening an issue to get feedback before spending much time. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the changes.
I hit the pre-processor.md page when trying to get
<?if?>to work (which is another story). I can happily pull together a PR if your project works like this.This change is more of a "test the water" to see if you would want this.
So please close this PR with either "sure have at it" or "sorry, not the way we do things". Either way I'll not be offended.
(and yes, I am working on an opensource project and FWIW I believe that Opensource only flourishes when people submit patches).