update dep, move to esm and require node v14 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional changing came in node v14
4 tasks
| module.exports = function isBuffer (obj) { | ||
| return obj != null && obj.constructor != null && | ||
| typeof obj.constructor.isBuffer === 'function' && obj.constructor.isBuffer(obj) | ||
| /** @returns {boolean} true if obj is a Buffer */ |
There was a problem hiding this comment.
a related potential improvement
Suggested change
| /** @returns {boolean} true if obj is a Buffer */ | |
| /** | |
| * Determine if an object is a Buffer | |
| * @param {unknown} obj | |
| * @returns {obj is Buffer} true if obj is a Buffer | |
| */ |
could be used with https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html
along side a tsconfig like
{
"include": ["*.js"],
"compilerOptions": {
"target": "ES2020",
"lib": ["ES2020"],
"module": "ES2020",
"moduleResolution": "node",
"allowJs": true,
"checkJs": true,
"declaration": true,
"emitDeclarationOnly": true
}
}to automatically generate the index.d.ts file, rather than having it hand-coded
which would also be related to #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional changing came in node v14