-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support sqlalchemy MappedColumn
#1143
base: main
Are you sure you want to change the base?
Conversation
These tests share the same structure and field names, so they conflict if not cleaned up.
This PR is failing one test because it does not have a label assigned. Do I need to open a separate issue to point to the PR? |
isinstance directly supports using a tuple of allowed types.
Hello, While trying to fix a problem probably similar to yours (I want to make a column deferrable but it can only be made on at the end of According to tests, this is fully compatible. Also it's slightly more readable: not_loaded: str = Field(sa_column_kwargs={"deferred": True})
# vs
not_loaded: str = Field(sa_type=mapped_column(String, deferred=True)) Maybe there's an underlying reason why this cannot be acceptable but I think it's worth sharing (and also will help me follow this pull request) |
MappedColumn
Reopening PR #896.
This PR adds a test with sqlmodel.orm.mapped_column working for sa_column. This test fails on current main.