Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed metrics import location on speech_dlm_criterion #5365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Efrainq07
Copy link

@Efrainq07 Efrainq07 commented Nov 2, 2023

Fixes issue #5366.
Fixes deprecated from fairseq import metrics changing the import with the new location from fairseq.logging import metrics on the speech_dlm_criterion used in the fairseq-train run on the SimpleLSTM tutorial.

@SasukeBLX
Copy link

@Efrainq07
I checked your fixed code and looked for same issue with below command on main branch (da8fb63).
find . -name '*.py' | xargs grep "import.*metrics" | less
As a result, There is only code where you mentioned.
I'm afraid that I am not a reviewer. I hope this pr is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants