Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Fairseq compatible with WandB when running in SageMaker so that experiments can be tracked #5316

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fdsig
Copy link

@fdsig fdsig commented Sep 7, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?

What does this PR do?

Fixes # (#5313)
Crashing in Sagmaker as a result of attempting to overwrite wandb config #5313

adds check if fairseq is being run in SM and then calls check and does not update config if running in SM

PR review

cc @vklyukin

Did you have fun?

Always fun to dive into new code and help folks track experiments.

Make sure you had fun coding 🙃

@fdsig fdsig changed the title Make Fairseq Compatible with WandB when running in SageMaker so that experiments can be tracked Make Fairseq compatible with WandB when running in SageMaker so that experiments can be tracked Sep 7, 2023
@fdsig fdsig changed the title Make Fairseq compatible with WandB when running in SageMaker so that experiments can be tracked Makes Fairseq compatible with WandB when running in SageMaker so that experiments can be tracked Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants