Skip to content

Fix missing react dependency in some addon umd builds #9919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flarnie merged 9 commits into from
Jun 12, 2017
Merged

Fix missing react dependency in some addon umd builds #9919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b11af7b
Test 'create-react-class' with fixtures
flarnie Jun 9, 2017
814be02
Rename fixtures testing create-react-class
flarnie Jun 10, 2017
2b7ea39
Prettify the unminified UMD build of `react-linked-input`
flarnie Jun 10, 2017
54bf912
Test state of `react-linked-input` and `create-fragment` before fix
flarnie Jun 10, 2017
1641237
Fix missing `React` in `react-linked-input` and `create-fragment`
flarnie Jun 10, 2017
862b57d
More adjustments to enable testing with fixtures
flarnie Jun 10, 2017
5f30b23
Remove all cruft from manually testing addons in fixtures
flarnie Jun 10, 2017
59b296b
Double to single quotes in 'react-linked-input'
flarnie Jun 12, 2017
3d6c422
remove random newline
flarnie Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions addons/react-addons-create-fragment/react-addons-create-fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
typeof exports === "object" &&
typeof module !== "undefined"
) {
module.exports=f()
module.exports=f(require('react'))
} else if (
typeof define === "function" &&
define.amd
) {
define([],f)
define(['react'],f)
} else {
var g;
if (typeof window !== "undefined") {
Expand All @@ -27,9 +27,9 @@
g.React.addons = {};
}

g.React.addons.createFragment = f()
g.React.addons.createFragment = f(g.React)
}
})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
})(function(React){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
/**
* Copyright 2015-present, Facebook, Inc.
* All rights reserved.
Expand Down Expand Up @@ -390,7 +390,7 @@ module.exports = createReactFragment;
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*
*
*/

function makeEmptyFunction(arg) {
Expand Down Expand Up @@ -542,4 +542,4 @@ if ("development" !== 'production') {

module.exports = warning;
},{"./emptyFunction":2}]},{},[1])(1)
});
});
Loading