[flow] annotate accumulate, accumulateInto and forEachAccumulated#7053
Merged
vjeux merged 1 commit intofacebook:masterfrom Jun 17, 2016
Merged
[flow] annotate accumulate, accumulateInto and forEachAccumulated#7053vjeux merged 1 commit intofacebook:masterfrom
vjeux merged 1 commit intofacebook:masterfrom
Conversation
|
@vjeux updated the pull request. |
Summary:
Trying to start adding flow types to files in React. I needed to add a script to package.json in order to run flow, flow-bin is already a dependency.
I had to rewrite the implementation a bit. Flow doesn't recognize
```
var currentIsArray = Array.isArray(current);
if (currentIsArray) {
// not refined
}
```
but the following does work
```
if (Array.isArray(current)) {
// refined
}
```
Test Plan:
npm run-script flow
npm run-script test accumulate
Reviewers: @zpao @spicyj
|
@vjeux updated the pull request. |
Member
|
FYI #1 |
Contributor
Contributor
Author
|
@keyanzhang are there any tracker tools already available? I'd love to see progress :) |
zpao
pushed a commit
that referenced
this pull request
Jul 8, 2016
[flow] annotate accumulate, accumulateInto and forEachAccumulated (cherry picked from commit 5b4dad3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to start adding flow types to files in React. I needed to add a script to package.json in order to run flow, flow-bin is already a dependency.
I had to rewrite the implementation a bit. Flow doesn't recognize
but the following does work
Test Plan:
npm run-script flow
npm run-script test accumulate
Reviewers: @zpao @spicyj