Browser testing

[subtleGradient]

No description provided.

[benjamn]

How confident are we about spaces in file names? I'd be tempted to just use underscores here.

[subtleGradient]

It's not passing every browser in testling-ci yet. I'm investigating.
Cf. https://ci.testling.com/subtleGradient/react

[benjamn]

I think this requires us to run grunt build before grunt test, so that build/react.js will be built. Wondering if we should make grunt test depend on grunt build.

[subtleGradient]

Yeah, I'm not 100% sure about this change. I did it so that I could get the tests running in a browser normally without having to rely on the phantomjs web server contortions.

[benjamn]

Can we not expect Testling-CI to run grunt for us?

[benjamn]

cc @spicyj who last worked with ReactWebWorker-test: thoughts?

[sophiebits]

No strong feelings, I was expecting someone to want to change the generic path earlier than now. Can we not just use a relative path here though? I think I'm actually just missing context on the purpose of this PR.

[subtleGradient]

I don't know how to get testling-ci to run grunt.
I do know that if you include a path in the "tests" section of the "testling" package.json thing it'll get run through browserify first. So maybe there's some way to piggyback on that somehow.

[benjamn]

Since you've got your own scope here, why not just

var parts = __filename.split('/');
parts.pop();
var __dirname = parts.join('/');

[benjamn]

@subtleGradient can you look into why Travis CI tests are failing?

Looks like something to do with ReactWebWorker timing out: https://travis-ci.org/facebook/react/builds/13216897

[subtleGradient]

@benjamn looking into it now…

[benjamn]

Not sure I see the point in making this a dynamic JS file instead of generating a simple HTML file. Am I missing something?

[subtleGradient]

testling-ci can load scripts like this, but it won't load an html file.

[subtleGradient]

Got testling-ci working with IE10 and probably more.
React apparently fails a few tests.

[subtleGradient]

Switching to SauceLabs…

[benjamn]

👍 looks legit

[subtleGradient]

The grunt-saucelabs implementation of jasmineRunner seems to be broken.
I'll have to fix it.

[benjamn]

Can we get rid of this file if we're using SauceLabs instead of Testling?

[benjamn]

Still want to get rid of this file if possible.

[subtleGradient]

I decided to remove testling and sauce labs as dependencies for this PR. I'll add sauce labs support in a separate PR.

[benjamn]

Maybe just if (key.indexOf("grunt-") === 0) grunt.loadNpmTasks(key);?

[subtleGradient]

Yeah, I just pasted this from somewhere. Dang my slackerly ways!

[benjamn]

Looking great! My final request is to make grunt test --debug (same command as before) keep the server running so you can run tests in local browser.

[subtleGradient]

You can run tests in a local browser by opening the test/index.html file, no server necessary.
If you need to keep the localhost:9999 server running for some reason you can use grunt connect:server:keepalive.

I'm not sure how to make it so that grunt test --debug runs something similar to grunt connect:server:keepalive, but I'm sure it's possible.

[subtleGradient]

This is what I've been doing to test changes really quickly…

1. Run chromedriver in one terminal window.[1]
2. Turn on the localhost:9999 server using grunt connect:server:keepalive in another terminal window.
3. Run grunt webdriver-jasmine:local in yet another terminal window.[2]

If you also want to test changes to any of the generated files you'll need to rebuild them as necessary with grunt build or whatever more specific task. This part could be made a little faster.

[1] Any webdriver server running on localhost:9515 will be used by the webdriver-jasmine:local task. You can use chromedriver or phantomjs --webdriver=9515 or whatever else you like. The webdriver-phantomjs task is essentially the same as phantomjs --webdriver=9515 except it kills it once its done.

[2] To keep the browser window open, pass the --webdriver-keep-open flag to grunt. e.g., grunt webdriver-jasmine:local --webdriver-keep-open. You can then refresh this page occasionally to manually test changes after rebuilding.