Clarify RTR native feature flags are fb specific#28679
Merged
jackpope merged 1 commit intofacebook:mainfrom Apr 1, 2024
Merged
Clarify RTR native feature flags are fb specific#28679jackpope merged 1 commit intofacebook:mainfrom
jackpope merged 1 commit intofacebook:mainfrom
Conversation
|
Comparing: 6cd6ba7...c6a7756 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Member
|
This does more then renaming the file. Could you clarify the summary for posterity? |
Contributor
Author
|
@kassens Updated title and description |
rickhanlonii
approved these changes
Apr 1, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Make it more clear that these flags aren't used in RN OSS. - Rename `packages/shared/forks/ReactFeatureFlags.test-renderer.native.js` to `packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js` - Remove RN OSS build cases consuming the feature flags since there is no RN OSS RTR build.
This was referenced Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it more clear that these flags aren't used in RN OSS.
packages/shared/forks/ReactFeatureFlags.test-renderer.native.jstopackages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js