RFC 6: createReactClass updates

[bvaughn]

This codemod corresponds with reactjs/rfcs/pull/6 and /pull/12028

Make create-react-class factory aware of the new "UNSAFE_" lifecycle names so that:

• It warns about spelling error for UNSAFE_componentWillRecieveProps.
• It doesn't trigger an invariant if one of the new lifecycle names are mixed in as overrides.

I've built addons/create-react-class locally and compared it to the 15.6.2 release in NPM to verify that the only changes between the two are the additions I've made with this PR. This should make the release very low risk.

[bvaughn]

CI failure is unexpected, given the limited scope of these changes.

Edit: Looks like the last commit to this branch (4c75c5b) also failed CI for this same reason, so I'm going to ignore it.

[bvaughn]

I don't think I actually need to care about the failing CI. The changes to the bundled create-react-class package are so minimal, it should be easy to verify them by hand when doing the NPM release.

[sebmarkbage]

What about the static one getDerivedStateFromProps? Do we not it to merge similarly as other mixin things?

[bvaughn]

Statics can't be defined on the object passed to the create-react-class factory, can they?

I've added tests for the combination of these two with 286df77 FWIW.

[sebmarkbage]

createClass({
  statics: {
    getDerivedStateFromProps() {
    }
  }
})

This approach also works with mixins.

[bvaughn]

Oh cool. I had no idea. 😄

Declaring the static method should work without any changes, although I've added a test for it (68f2fe7).

Mixing it in wouldn't, but I think that's reasonable since...what would it mean to mix two of those methods? What would the return value be?

[bvaughn]

This should be ready for review 😄

I'm happy to publish to NPM once it's merged. I've done a dry-run locally and verified that all of the tests for this addon pass and no unexpected changes are in the build.

[gaearon]

Mixing it in wouldn't, but I think that's reasonable since...what would it mean to mix two of those methods? What would the return value be?

Should work the same way as getInitialState is already being merged.

[bvaughn]

Should work the same way as getInitialState is already being merged.

Eh, yuck. 😄 Okay.

[bvaughn]

I've added support for static getDerivedStateFromProps to be mixed in. I also added tests for this as well as the getInitialState instance mixin.

[gaearon]

This is new to me. Why?

[bvaughn]

Wow. Sorry! Looks like I fucked up there.

[gaearon]

Haha no worries. Fresh eyes always help 👀

[gaearon]

This makes sense to me

[bvaughn]

Thanks!

Releasing this should be pretty simple. (Just run yarn build from within the addons/create-react-class directory and compare to the latest release in NPM.)

I'll wait and release it just before the 16.3 release though, so as to avoid confusion.