Support new OS models: Zephyr and Yi #392
Conversation
# Conflicts: # spacy_llm/tasks/builtin_task.py
…done by spaCy's slicing directly.
…for handling both types of tasks. Update tests.
# Conflicts: # spacy_llm/tests/tasks/test_rel.py
| return Doc.from_docs(list(shards), ensure_whitespace=True) | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings( | ||
| "ignore", | ||
| category=UserWarning, | ||
| message=".*Skipping .* while merging docs.", | ||
| ) | ||
| return Doc.from_docs(list(shards), ensure_whitespace=True) |
There was a problem hiding this comment.
Not sure where this edit is coming from?
There was a problem hiding this comment.
It's just a drive-by because I noticed the warnings filter is missing here 🙃 I can move this into a separate PR, if you mind having it in here.
There was a problem hiding this comment.
It's all just a bit confusing with the huge (mostly unrelated) git history etc - I do in general appreciate more "atomic" PRs ;-)
There was a problem hiding this comment.
I do in general appreciate more "atomic" PRs ;-)
I know 🫣
It's all just a bit confusing with the huge (mostly unrelated) git history etc
Yeah, I don't know why that's the case. The branches should all be updated.
|
Looks like the GPU tests failed... |
I couldn't figure out why exactly the CI runner fails with |
|
Let's finish #428 first, then resolve the conflicts and finalize this one. |
|
This was unintentionally closed when I reset the |
Description
Add support for OS/HF models:
Corresponding documentation PR
explosion/spaCy#13174
Types of change
New feature.
Checklist
testsandusage_examples/tests, and all new and existing tests passed. This includespytestran with--external)pytestran with--gpu)