refactor(dns): Update dns manipulation to egoscale v3 #640
Conversation
1a8531f
to
f3a9161
Compare
cmd/dns_add.go
Outdated
| }) | ||
| ctx := gContext | ||
| err = decorateAsyncOperations(fmt.Sprintf("Adding DNS record %q to %q...", rType, domain.UnicodeName), func() error { | ||
|
|
cmd/dns_add.go
Outdated
| }) | ||
|
|
|
This PR looks very good, :) I will do a second review once you applied some of them |
| @@ -55,8 +55,7 @@ func addDomainRecord(domainIdent, name, rType, content string, ttl int64, priori | |||
|
|
|||
| ctx := gContext | |||
| err = decorateAsyncOperations(fmt.Sprintf("Adding DNS record %q to %q...", rType, domain.UnicodeName), func() error { | |||
|
|
|||
| recordType, err := StringToDNSDomainRecordRequestType(rType) | |||
| recordType := v3.CreateDNSDomainRecordRequestType("TEST") | |||
There was a problem hiding this comment.
looks like you forgot to change this?
cmd/dns_remove.go
Outdated
| @@ -54,11 +54,7 @@ func removeDomainRecord(domainIdent, recordIdent string, force bool) error { | |||
| } | |||
|
|
|||
| _, err = globalstate.EgoscaleV3Client.Wait(ctx, op, v3.OperationStateSuccess) | |||
| if err != nil { | |||
| return fmt.Errorf("exoscale: error while waiting DNS record deletion: %w", err) | |||
There was a problem hiding this comment.
You're right that these can be removed, but I like these error messages. Makes it easier to find out where an error happened when you read the logs. IMHO these can be kept :)
There was a problem hiding this comment.
@mlec1 What I wanted to point out here in this PR, if you were not wrapping/modifying the error, it was not needed to add an extra condition and return it directly instead.
But in the case you want to add more context on the error like here, that is fine 👍 you can keep it.
I have no strong opinion here, but if you decided to add more context to the error here, looks good to me.
| // Function to get the DNSDomainRecordRequestType from a string | ||
| func StringToDNSDomainRecordRequestType(recordType string) (v3.CreateDNSDomainRecordRequestType, error) { |
There was a problem hiding this comment.
| // Function to get the DNSDomainRecordRequestType from a string | |
| func StringToDNSDomainRecordRequestType(recordType string) (v3.CreateDNSDomainRecordRequestType, error) { | |
| // StringToDNSDomainRecordRequestType gets the DNSDomainRecordRequestType from a string | |
| func StringToDNSDomainRecordRequestType(recordType string) (v3.CreateDNSDomainRecordRequestType, error) { |
|
|
||
| // Function to get the DNSDomainRecordRequestType from a string | ||
| func StringToDNSDomainRecordRequestType(recordType string) (v3.CreateDNSDomainRecordRequestType, error) { | ||
| // Lookup the record type in the map |
There was a problem hiding this comment.
| // Lookup the record type in the map |
IMHO code is enough explicit here
Description
Update dns manipulation to egoscale v3
Checklist
(For exoscale contributors)
Testing
Manual test of the different dns manipulation.