Update lodestar source build to use pnpm #2439
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
moving to draft until our next release is out |
Collaborator
|
You are right that source builds can break for months and no one notices :D. Thanks for this PR, my CI does notice. On Tuesdays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our next release (v1.39.0) we will be moving from
yarntopnpmas our package manager. This breaks the source build in eth-docker so we will need to update it.I suspect that nobody actually uses
Dockerfile.sourcebut who knows, we need to merge this when our new release comes out, the problem is that it will break versions<1.39.0as those can only be build usingyarn.