Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos build #15982

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix macos build #15982

wants to merge 4 commits into from

Conversation

clonker
Copy link
Member

@clonker clonker commented Apr 4, 2025

There were some problems in the macos CI build.

  • Starting with jsoncpp which could easily be solved by removing it, it doesn't seem like it is used anywhere anymore. (as seen here Add support for upcoming Boost 1.88.0 #15976)
  • Then some issues came up with includes from boost. Usually, as these are imported / found targets, they should be treated as system libraries (which they also are, also on the failing jobs (as seen here Mask generator optimizations #15935). It seems to be a compatibility issue of CMake 4.0.0 with Apple Clang 15. Downgrading it resolved the issue but this can only be a temporary fix, if at all.
  • Finally CMake 3.30 deprecated FindBoost with CMake-vendored find package script, instead they prefer to rely on a Boost cmake config (see CMP0167), which is delivered since Boost 1.70. On MacOS and Linux we have Boost 1.67 as minimum version and for CMake it is 3.13, so the whole thing is conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant