p2p/discover/v5wire: use Whoareyou.ChallengeData instead of storing encoded packet #31547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packet This changes the challenge resend logic again to use the existing ChallengeData field of v5wire.Whoareyou instead of storing a second copy of the packet in Whoareyou.Encoded. It's more correct this way since ChallengeData is supposed to be the data that is used by the ID verification procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the challenge resend logic again to use the existing
ChallengeDatafield ofv5wire.Whoareyouinstead of storing a second copy of the packet inWhoareyou.Encoded. It's more correct this way sinceChallengeDatais supposed to be the data that is used by the ID verification procedure.Also adapts the cross-client test to verify this behavior.
Follow-up to #31543