Update action versions and EDM version #183
Conversation
|
@corranwebster Another one for you, if you have the bandwidth 🙏 |
| uses: GabrielBB/xvfb-action@v1 | ||
| with: | ||
| run: edm run -- python etstool.py test --runtime=${{ matrix.runtime }} | ||
| run: edm run -- python etstool.py test --runtime=${{ matrix.runtime }} |
There was a problem hiding this comment.
You probably need to use xvfb-run -a here to run in a framebuffer, but I note that we're not installing either Qt or Wx so this won't actually do any GUI tests anyway.
Possibly open an issue for this?
There was a problem hiding this comment.
Right - I considered this (see the description), but we don't need a framebuffer at all for these tests, it doesn't seem worth it.
Possibly open an issue for this?
You mean for installing Qt (or Wx) for test run purposes? Do we even have any tests that exercise the GUI? Nothing appears to be being skipped in the test run.
There was a problem hiding this comment.
Hmm. I see that our PyPI-based workflow does do the Ubuntu / non-Ubuntu split, but now I'm wondering why.
We're getting warnings about outdated GitHub Actions. This PR brings all actions up to the most recent versions.
I'm not yet sure whether it's safe to remove the use of GabrielBB/xvfb-action@v1 altogether or whether we need to introduce an explicit use ofxvfb-run -aon Ubuntu workers. Testing that workflow is currently blocked by thepython setup.py installfailure fixed in #182.Update: #182 is merged, and it looks as though everything's working despite the removal of the xvfb-action.
Test run: https://github.com/enthought/scimath/actions/runs/8112365378