Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to test versions; drop Python 3.7 #180

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

mdickinson
Copy link
Member

This PR updates the Python test versions to include Python 3.12 and exclude Python 3.7 (which is now beyond end-of-life).

@mdickinson mdickinson closed this Feb 16, 2024
@mdickinson mdickinson reopened this Feb 16, 2024
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do we want to add python_requires to the setup.py as well?

@mdickinson
Copy link
Member Author

Do we want to add python_requires to the setup.py as well?

Yes, that would be good. Done in b2fedab

@mdickinson
Copy link
Member Author

Also applied some formatting fixes to setup.py in 9d562d1, since I was looking at a wall of red underlines for the setup call in VS Code.

@mdickinson
Copy link
Member Author

Okay, this is messier than I was expecting. I'm going to revert back to the original commit and just merge that, then look at what it takes to remove Python 3.6 support properly.

@mdickinson mdickinson merged commit 29108c0 into main Mar 8, 2024
19 checks passed
@mdickinson mdickinson deleted the dev/add-python312-to-test-matrix branch March 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants