Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for toolbar actions #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonysyu
Copy link

@tonysyu tonysyu commented Aug 8, 2014

QMenu.addAction has a key-sequence argument in it's signature, but QToolBar.addAction doesn't, so the initialization of keyboard shortcuts is a bit different.

@tonysyu
Copy link
Author

tonysyu commented Sep 2, 2014

Is there someone assigned as the gatekeeper for pyface? @rkern: Could you review or suggest someone for review?

@pankajp
Copy link
Contributor

pankajp commented Sep 3, 2014

While this would be the correct thing to do, i suspect it may break many applications which use same action in toolbar and menubar, since now Qt would start showing ambiguous shortcut overload warnings.

@dpinte
Copy link
Member

dpinte commented Mar 13, 2015

I suggest not to push this in 4.5.0 as the idea of 4.5.0 is to get a stable released version for the apps like Canopy that are currently working out of master.

@dpinte dpinte added this to the 4.6.0 version milestone Apr 1, 2015
@corranwebster
Copy link
Contributor

I find that I often end up with two versions of an Action anyway - typically you want an icon for toolbar Actions, but don't for menu actions.

@rahulporuri rahulporuri removed this from the 4.6.0 version milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants