Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix to use Django 5.2 stable version #9679

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

TGoddessana
Copy link
Contributor

Description

image

Now that django 5.2 is generally available, update the tox test from using a beta version of Django 5.2 to the general release.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, small clean-up. Although this technically doesn't change anything (tox started to pick up the Django 5.2 final as soon as it got released).

@TGoddessana
Copy link
Contributor Author

Ah, we specified a minimum version, so I guess that's how it works :) Thanks for reviewing the PR!

@browniebroke
Copy link
Member

There is some satisfaction of having all versions consistent... We could switch to>=X.Ya1 everywhere (taking inspiration from @adamchainz projects, for example)

@ulgens
Copy link

ulgens commented Apr 3, 2025

Not sure about the benefit with >=X.Ya1 but I agree that it looks cleaner when all consistent and my vote is for >=X.Y

@browniebroke
Copy link
Member

Not sure about the benefit with >=X.Ya1

Less churn: we update the matrix once when first adding support and don't bother with following up with other PRs when the final version is out

@TGoddessana
Copy link
Contributor Author

Yeah, I think it's more of a coding convention than a technical issue, and once you've chosen that convention, I think we'll have fewer problems writing or reviewing code like this in the future. Ideally, the DRF should be released along with the major release of Django, so we could choose the following workflow:

  1. (Optional) When a Django alpha or beta is released, add the version to tox testing and leave the pr as a draft.
  2. a major version of Django is released.
  3. quickly add a full release test to Drf's tox test and merge it into the master branch.

@browniebroke browniebroke changed the title Add Django 5.2 stable version support Update test matrix to use Django 5.2 stable version Apr 4, 2025
@browniebroke browniebroke merged commit 5c21fa7 into encode:master Apr 4, 2025
7 checks passed
@TGoddessana
Copy link
Contributor Author

Thanks for reviewing my PR, all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants