Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum type for ordering fields. #9658

Closed
wants to merge 1 commit into from

Conversation

MHMK2002
Copy link

This pull request addresses an issue with the ordering schema type in the Django REST Framework. The changes include:

  • Bug Fix: Corrected the ordering schema type to ensure proper functionality.
  • Code Improvements: Refactored the OrderingFilter class to enhance readability and maintainability.

Changes:

  • Modified rest_framework/filters.py to fix the ordering schema type.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you are trying to fix. any related issue? this will need additional test case and should not breaking existing codes

@MHMK2002
Copy link
Author

MHMK2002 commented Mar 1, 2025

I'm not sure what you are trying to fix. any related issue? this will need additional test case and should not breaking existing codes

Hello. There is a type error in generated document. I will fix breaking tests.

@tomchristie
Copy link
Member

Thanks for your consideration.

https://github.com/encode/django-rest-framework/blob/master/CONTRIBUTING.md

At this point in its lifespan we consider Django REST framework to be essentially feature-complete. We may accept pull requests that track the continued development of Django versions, but would prefer not to accept new features or code formatting changes.

@tomchristie tomchristie closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants