Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop coreapi support for DRF 3.17 #9583

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

TGoddessana
Copy link
Contributor

Description

refs #8453

As discussed in #8453, we are deprecating the coreapi for drf 3.17.

I read the discussion in detail, and I'm wondering if it was decided to “leave all schema generation logic in the library that generates the schema (drf-spectacular), and drf will not be involved in schema generation” (drf-spectacular will be part of drf?) The comments in the linked discussion say that...

Yes. The idea would be to leave (just) the extension points in place, as they are.

@TGoddessana TGoddessana force-pushed the drop-coreapi-support branch from 951c960 to e8c0236 Compare March 15, 2025 17:05
@TGoddessana
Copy link
Contributor Author

TGoddessana commented Mar 21, 2025

Question while working with PR.

The documentation says: “Support for generating default schemas will be moved to a separate package and then removed”. For this PR, should we remove coreapi and everything related to it, or all code related to the whole rest_framework/schemas/ package?

If you need to remove everything related to schemas from the Rest Framework, you can remove most of the code, tests, etc. in /schemas. What do you team think about this?

@TGoddessana
Copy link
Contributor Author

@auvipy I'm sorry if the tags are annoying. But this is the only place we can make design decisions about PR, and I'd love to hear your thoughts on what I should do..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant