Update authentication.py Code Simplification #9502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced redundant checks in the authenticate method by combining the conditions for the length of auth. Removed the unnecessary elif in favor of an if to make the code flow clearer
akx
suggested changes
Aug 27, 2024
Comment on lines
-170
to
-175
| """ | ||
| A custom token model may be used, but must have the following properties. | ||
|
|
||
| * key -- The string identifying the token | ||
| * user -- The user to which the token belongs | ||
| """ |
There was a problem hiding this comment.
Why would this need to be removed?
Comment on lines
-183
to
-188
| if len(auth) == 1: | ||
| msg = _('Invalid token header. No credentials provided.') | ||
| raise exceptions.AuthenticationFailed(msg) | ||
| elif len(auth) > 2: | ||
| msg = _('Invalid token header. Token string should not contain spaces.') | ||
| raise exceptions.AuthenticationFailed(msg) |
There was a problem hiding this comment.
What happened to these error messages? The idea is to validate the shape of the token header; with your proposed code, an invalid token will go unnoticed.
Comment on lines
-193
to
+182
| msg = _('Invalid token header. Token string should not contain invalid characters.') | ||
| raise exceptions.AuthenticationFailed(msg) | ||
| raise exceptions.AuthenticationFailed( | ||
| _('Invalid token header. Token string should not contain invalid characters.') | ||
| ) |
auvipy
requested changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced redundant checks in the authenticate method by combining the conditions for the length of auth. Removed the unnecessary elif in favor of an if to make the code flow clearer
Note: Before submitting a code change, please review our contributing guidelines.
Description
Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use
refs #...in the description of the pull request.