set boolean false as type of empty class

[rodolvbg]

Description

https://github.com/encode/django-rest-framework/discussions/9120

[auvipy]

I'm not 100% sure about the usage of the proposed change. can you share some examples and possibly unit/integrations tests as well to verify the changes proposed?

[rodolvbg]

I think in #9120 it's a bit explained but I'll rewrite it here anyway.

I think that when making comparisons with data whose value is empty you can consider it as False.

in the case I explained in #9120

data = empty
if not data:

here you would be saying that data is None, False, "", [] or is empty.

[carltongibson]

Empty is a sentinel value, used with is explicitly to distinguish from
False or None.

[adamchainz]

@carltongibson are you expressing an opinion against here? You weren’t explicit.

I’m against it because it’s backward incompatible for code like:

if not x:
   thing1()
elif x is empty:
   thing2()

A slightly odd way to write it but still valid. I don’t think there’s a reasonable deprecation path here.

[carltongibson]

Yes, sorry. To be explicit: I don't see any positive reason for this change (and many potential issues). I'd be 👎

[auvipy]

thanks folks