Conversation
de7d39a to
5da5ec7
Compare
5da5ec7 to
6597cd3
Compare
Oowoosh0
reviewed
Mar 26, 2025
Contributor
Oowoosh0
left a comment
There was a problem hiding this comment.
Overall it looks good to me. Just a couple of smaller issues I found:
- When nothing matches the search term then the "Queue is Empty" Placeholder gets shown. Probably it would be better to display a placeholder here that reflects that the search didn't return any results.
- There are some performance issues if the queue is larger (couple hundred songs). The UI freezes for a bit on every character entered into the search bar. I guess it is unavoidable that filtering a longer list takes a bit, but ideally the UI should stay responsive.
- If I clear the queue while a search is applied and then add new songs that search is automatically applied again. Maybe it's better to reset the search filter when clearing the queue. But I'm not really sure which of the two would be the expected behaviour for most people.
ryonakano
reviewed
May 1, 2025
Member
|
@Oowoosh0 Pushed a couple commits to address review comments. I think performance should be better here since we've switched to ListView previously |
ryonakano
reviewed
Aug 16, 2025
ryonakano
reviewed
Aug 30, 2025
Member
|
@ryonakano fixed! |
ryonakano
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #794
Introduce a search bar widget since we are probably gonna need search in more places if we're going to implement the library.