fix: enable postinstall #285

fengmk2 · 2025-02-04T05:19:42Z

Summary by CodeRabbit

Chores
- Updated the installation process to ensure all necessary setup routines run automatically, enhancing consistency and reliability.
- Refined the configuration used during setup to improve file resolution, contributing to a smoother installation experience.
Documentation
- Updated the project title in the README to reflect the new branding.
Tests
- Modified specific test cases to be skipped during execution, allowing for focused testing on other cases without removing the tests entirely.

vercel · 2025-02-04T05:19:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
egg-bin	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 5:29am

coderabbitai · 2025-02-04T05:19:51Z

Walkthrough

The changes adjust the behavior during the package installation process by replacing a conditionally skipped script with one that always executes. The package.json now runs the post-install script unconditionally. Additionally, the file path in the postinstall.mjs file has been updated to include the explicit .js extension when resolving the egg-ts-helper module. The README title has been updated to reflect a new naming convention, and two test cases have been modified to skip execution.

Changes

File(s)	Change Summary
`package.json`	Updated `"egg"` dependency from `"beta"` to `"^4.0.7"`, removed `"postinstall-skip"` script, added `"postinstall"` script.
`scripts/postinstall.mjs`	Updated module resolution from `"egg-ts-helper/dist/bin"` to `"egg-ts-helper/dist/bin.js"`
`README.md`	Changed title from `# egg-bin` to `# @eggjs/bin`
`test/commands/cov.test.ts`	Modified test case from `it('should grep pattern without error', ...)` to `it.skip('should grep pattern without error', ...)`
`test/commands/test.test.ts`	Modified test case from `it('should grep pattern without error', () => {` to `it.skip('should grep pattern without error', () => {`

Sequence Diagram(s)

sequenceDiagram
  participant N as NPM
  participant P as Package.json Script
  participant S as Postinstall Script
  participant M as Module Resolver
  
  N->>P: Trigger postinstall
  P->>S: Execute "node scripts/postinstall.mjs"
  S->>M: Call importResolve("egg-ts-helper/dist/bin.js")
  M-->>S: Module resolved

Poem

I'm a bouncing bunny in the code burrow,
Hopping through changes both swift and mellow.
Postinstall now leaps with no delay,
With '.js' clear in its bright display.
Cheers from this rabbit—a joyous code ballet!

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51459d1 and 69bb1c5.

📒 Files selected for processing (4)

README.md (1 hunks)
package.json (2 hunks)
test/commands/cov.test.ts (1 hunks)
test/commands/test.test.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

README.md

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: Node.js / Test (windows-latest, 23)
GitHub Check: Node.js / Test (windows-latest, 18)
GitHub Check: Node.js / Test (windows-latest, 22)
GitHub Check: Node.js / Test (windows-latest, 20)
GitHub Check: Node.js / Test (windows-latest, 18.19.0)
GitHub Check: Node.js / Test (ubuntu-latest, 23)
GitHub Check: Node.js / Test (ubuntu-latest, 22)
GitHub Check: Node.js / Test (ubuntu-latest, 20)
GitHub Check: Node.js / Test (ubuntu-latest, 18.19.0)
GitHub Check: Node.js / Test (ubuntu-latest, 18)
GitHub Check: Node.js / Test (macos-latest, 23)
GitHub Check: Node.js / Test (macos-latest, 22)
GitHub Check: Node.js / Test (macos-latest, 18.19.0)
GitHub Check: Node.js / Test (macos-latest, 20)
GitHub Check: Node.js / Test (macos-latest, 18)

🔇 Additional comments (2)

test/commands/cov.test.ts (1)

133-143: Verify the reason for skipping the grep pattern test.

The test case for grepping patterns has been skipped. This test appears to be testing an important functionality - the ability to filter tests using grep patterns. Skipping this test could leave potential issues undetected.

Could you clarify why this test needs to be skipped? If there are known issues, consider:

Fixing the underlying issue instead of skipping the test

Adding a comment explaining why the test is skipped

Creating a tracking issue for addressing this later

Additionally, the debug line has been uncommented, which might not be intentional.

test/commands/test.test.ts (1)

160-170: Verify the reason for skipping the grep pattern test.

Similar to the coverage test file, this test case for grepping patterns has been skipped. This appears to be a coordinated change across test files, suggesting a systemic issue with the grep pattern functionality.

Could you clarify:

Is there a known issue with the grep pattern functionality?

Are there any error logs or stack traces that led to this decision?

Should we create a tracking issue to address this in both test files?

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-02-04T05:20:40Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected] 🔁 npm/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+194`	21.3 MB	fengmk2
npm/[email protected]	network Transitive: environment, filesystem	`+15`	1.37 MB	titanism
npm/[email protected]	environment, filesystem, unsafe	`+3`	509 kB	jonaskello
npm/[email protected]	None	`0`	28.7 kB	fengmk2
npm/[email protected]	environment, filesystem, shell	`+29`	1.49 MB	isaacs
npm/[email protected]	None	`+3`	207 kB	fengmk2

View full report↗︎

pkg-pr-new · 2025-02-04T05:20:49Z

Open in Stackblitz

npm i https://pkg.pr.new/eggjs/bin/@eggjs/bin@285

commit: 69bb1c5

[skip ci] ## [7.0.3](v7.0.2...v7.0.3) (2025-02-04) ### Bug Fixes * enable postinstall ([#285](#285)) ([4406d92](4406d92))

codecov · 2025-02-04T05:36:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (fe6738f) to head (69bb1c5).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          22       22           
  Lines        1070     1070           
  Branches      177      170    -7     
=======================================
  Hits         1025     1025           
  Misses         45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: enable postinstall

51459d1

vercel bot deployed to Preview February 4, 2025 05:19 View deployment

f

69bb1c5

vercel bot deployed to Preview February 4, 2025 05:29 View deployment

fengmk2 merged commit 4406d92 into master Feb 4, 2025
17 of 24 checks passed

fengmk2 deleted the enable-postinstall branch February 4, 2025 05:34

fengmk2 pushed a commit that referenced this pull request Feb 4, 2025

Release 7.0.3

f0ed180

[skip ci] ## [7.0.3](v7.0.2...v7.0.3) (2025-02-04) ### Bug Fixes * enable postinstall ([#285](#285)) ([4406d92](4406d92))

coderabbitai bot mentioned this pull request Apr 19, 2025

fix: properly quote paths #289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: enable postinstall #285

fix: enable postinstall #285

Uh oh!

fengmk2 commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

socket-security bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: enable postinstall #285

fix: enable postinstall #285

Uh oh!

Conversation

fengmk2 commented Feb 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

socket-security bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 4, 2025 •

edited

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Feb 4, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading