Skip to content

Tags: eddie-wang/node

Tags

electron-v1.6.9

Toggle electron-v1.6.9's commit message
lib: fix event race condition with -e

Commit c5b07d4 ("lib: fix beforeExit not working with -e") runs the
to-be-evaluated code at a later time than before because it switches
from `process.nextTick()` to `setImmediate()`.

It affects `-e 'process.on("message", ...)'` because there is now a
larger time gap between startup and attaching the event listener,
increasing the chances of missing early messages.  I'm reasonably
sure `process.nextTick()` was also susceptible to that, only less
pronounced.

Avoid the problem altogether by evaluating the code synchronously.
Harmonizes the logic with `Module.runMain()` from lib/module.js
which also calls `process._tickCallback()` afterwards.

PR-URL: nodejs/node#11958
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>

electron-v1.6.3

Toggle electron-v1.6.3's commit message
Bump NODE_MODULE_VERSION to 53

This matches the number in nodejs/node#10992.

electron-v1.6.1

Toggle electron-v1.6.1's commit message
Bump NODE_MODULE_VERSION to 53

This matches the number in nodejs/node#10992.

electron-v1.6.0

Toggle electron-v1.6.0's commit message
Bump NODE_MODULE_VERSION to 53

This matches the number in nodejs/node#10992.

electron-v1.5.1

Toggle electron-v1.5.1's commit message
Add missing return value to node::url::To{Ascii,Unicode}

electron-v1.5.0

Toggle electron-v1.5.0's commit message
Add missing return value to node::url::To{Ascii,Unicode}

electron-v1.4.14

Toggle electron-v1.4.14's commit message
Call process.log from fallback stream on Windows

electron-v1.3.15

Toggle electron-v1.3.15's commit message
Allow use_openssl_def to be overwritten

electron-v1.3.7

Toggle electron-v1.3.7's commit message
Allow use_openssl_def to be overwritten

atom-shell-v1.3.6

Toggle atom-shell-v1.3.6's commit message
Allow use_openssl_def to be overwritten