Bug/target table perfomance #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SirWayne <[email protected]>
by the ui. fix the performance issue. Issue was the selection of targets. The table needs very long to calculate the scroll position. Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
| * | ||
| * @return the provider bean | ||
| */ | ||
| @Bean |
Contributor
There was a problem hiding this comment.
Why we adding the bean into the AutoConfiguration if you create the HawkbitEventProvider by our own with new in the constructor of the example app? I guess we don't need to provide the autoconfiguration for this, do we? Or otherwise we should annotate it with @ConditionalMissingBean
Contributor
Author
There was a problem hiding this comment.
You're right. thanks
Maybe if somone would like to extend the UI, it's simpler to add a own provider with new events. For this reason i create a bean into the AutoConfiguration.
Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
Signed-off-by: SirWayne <[email protected]>
Contributor
|
please resolve the conflicts so the branch can be merged with the master, thanks. |
|
|
||
| private static final Set<Class<? extends Event>> SINGLE_EVENTS = new HashSet<>(); | ||
|
|
||
| static { |
Contributor
There was a problem hiding this comment.
1 static block
fix hashset size
- Use 1 static block Signed-off-by: SirWayne <[email protected]>
…ERFOMANCE # Conflicts: # hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/push/DelayedEventBusPush Strategy.java
Contributor
|
I have taken the liberty to merge this for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs very long to calculate the scroll position. After deletion of a target the table row the scroll postion is not set anymore.