Prevent crash propagation from DWM#11417
Merged
himgoyalmicro merged 10 commits intomainfrom Feb 4, 2026
Merged
Conversation
harshit7962
previously approved these changes
Feb 3, 2026
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Standard/NativeMethods.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Standard/NativeMethods.cs
Outdated
Show resolved
Hide resolved
dipeshmsft
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It’s possible for DWM to crash or exit unexpectedly, and when that happens,
DwmExtendFrameIntoClientAreareturns a failure.This change adds a safety check to prevent that failure from propagating and causing a crash in WPF and reverting the app to the previous behavior.
We will only crash if we encounter Invalid Args exception.
Customer Impact
Possibly lesser crashes in fluent and might help in fluent adoption
Regression
N/A
Testing
Local Build Pass
Sample Application Testing
Tested with a runtime application
Risk
Low, things are very much in parity with previous impl.
Microsoft Reviewers: Open in CodeFlow