You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main goal is to enable the rule that all [Fact] methods are in public types.
We'll need a custom rule to check that [Fact] methods are themselves public.
Add reference in test_dependencies.csproj
Set RunAnalyzers in Directory.Build.props for merged test groups
Mostly disable other analyzer rules
Clean a few warnings - notably enable a few tests in HardwareIntrinsics by making them public
- Add reference in test_dependencies.csproj
- Set RunAnalyzers in Directory.Build.props for merged test groups
- Mostly disable other analyzer rules
- Clean a few warnings - notably enable a few tests in HardwareIntrinsics
by making them public
PTAL @trylek@jkoritzinsky - one question is perhaps whether we want to just disable the .NET analyzers at the top-level all across src/tests rather than disabling-on-demand/fixing some/etc. Thanks for pointing me in the right direction! A follow up PR will be needed with a custom rule to check the method itself.
@markples we can use an editorconfig file like CodeAnalysis.tests.globalconfig to configure the analyzers.
Take a look at the root Directory.Build.props file around line 380 where we modify the editorconfig files. We can do the same thing in src/tests to disable the analyzers we don't want for the test projects.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main goal is to enable the rule that all [Fact] methods are in public types.
We'll need a custom rule to check that [Fact] methods are themselves public.