[wasm] Always allocate when computing temp path#81085
Merged
maraf merged 3 commits intodotnet:mainfrom Jan 26, 2023
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsCloses #73721
|
Member
Author
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Jan 24, 2023
Member
Member
Author
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
reviewed
Jan 25, 2023
Member
Author
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
approved these changes
Jan 26, 2023
jkotas
approved these changes
Jan 26, 2023
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4016125533 |
Member
|
Emscripten landed fix for it emscripten-core/emscripten#18914 perhaps we could revert this change after we receive the new emscripten version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm implementation of
__randnameuses pointer address as another entry into the randomness.https://github.com/emscripten-core/emscripten/blob/085fe968d43c7d3674376f29667d6e5f42b24966/system/lib/libc/musl/src/temp/__randname.c#L13
We may get the same random name if the same pointer passed twice before the clock ticks. The issue in the upstream repository is emscripten-core/emscripten#18591.
We have decided to take the simplest solution at the moment and consider a better one as part of the WASI file system implementation #81210
Fixes #73721