improve SendFileGetsCanceledByDispose test#79718
Merged
wfurt merged 1 commit intodotnet:mainfrom Dec 16, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe test Is flaky and failing in CI occasionally. I was able to reproduce the failure easily by adding small delay just before the I was originally thinking about simple catching the ODE but at the end I decided to change the logic. By reading from the other end I assure the sending operation actually started. One byte does not really change the logic that assumes that large data would full the socket buffer and block. fixes #75354
|
MihaZupan
approved these changes
Dec 15, 2022
This was referenced Dec 15, 2022
liveans
approved these changes
Dec 16, 2022
Member
Author
|
wasm test failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test Is flaky and failing in CI occasionally. I was able to reproduce the failure easily by adding small delay just before the
SendFileAsyncit seems like if creating of the test file takes longer than usually this would fail.I was originally thinking about simple catching the ODE but at the end I decided to change the logic. By reading from the other end I assure the sending operation actually started. One byte does not really change the logic that assumes that large data would full the socket buffer and block.
fixes #75354