Avoid some unnecessary static readonly arrays#72727
Merged
stephentoub merged 4 commits intodotnet:mainfrom Jul 24, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThese changes are factored out of #70179, which is looking more and more unlikely to land for .NET 7 (the compiler changes it depends on haven't been merged yet as they depend on a versioning issue that hasn't been sorted out yet). This set of changes doesn't depend on those compiler features.
|
jkotas
reviewed
Jul 24, 2022
...braries/System.Diagnostics.FileVersionInfo/src/System/Diagnostics/FileVersionInfo.Windows.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jul 24, 2022
jkotas
reviewed
Jul 24, 2022
src/libraries/Common/src/Interop/Windows/Version/Interop.VerQueryValue.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are factored out of #70179, which is looking more and more unlikely to land for .NET 7 (the compiler changes it depends on haven't been merged yet as they depend on a versioning issue that hasn't been sorted out yet). This set of changes doesn't depend on those compiler features.