Skip to content

Remove wrong cgroups assert#72372

Merged
janvorli merged 2 commits intodotnet:mainfrom
janvorli:remove-cgroups-assert
Jul 22, 2022
Merged

Remove wrong cgroups assert#72372
janvorli merged 2 commits intodotnet:mainfrom
janvorli:remove-cgroups-assert

Conversation

@janvorli
Copy link
Member

When detecting the current cgroup version on Linux, checked and
debug builds assert when the filesystem type of /sys/fs/cgroup is
neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes
the assert and considers it as "no cgroup support". This is the case
e.g. in chroot environment.
Release builds already have this behavior.

Close #62960

When detecting the current cgroup version on Linux, checked and
debug builds assert when the filesystem type of /sys/fs/cgroup is
neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes
the assert and considers it as "no cgroup support".
Release builds already have this behavior.

Close dotnet#62960
@janvorli janvorli added this to the 7.0.0 milestone Jul 18, 2022
@janvorli janvorli requested a review from omajid July 18, 2022 13:01
@janvorli janvorli self-assigned this Jul 18, 2022
@janvorli janvorli requested a review from jkotas July 18, 2022 13:24
Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky
Copy link
Member

Could you also fix up the third fork of this file here?

assert(!"Unexpected file system type for /sys/fs/cgroup");

@janvorli
Copy link
Member Author

Ah, I have forgotten that nativeaot had one too.

@janvorli
Copy link
Member Author

@dotnet/dnceng The test legs finished running already, but the build analysis shows a page saying that once the tests complete, the analysis will be there. Is that a known issue? I have restarted a leg before, so it might be related.

@riarenas
Copy link
Contributor

@janvorli Build analysis suffered an outage that was fixed around 3:10 PM PT. As far as I understand, the analysis will be lost for builds completed while the outage was ongoing.

@janvorli
Copy link
Member Author

There are two libraries tests that keep failing on Windows in the legs of this CI. I've tried to restart the tests, but they still failed. Since my change is in purely Unix code, I'm merging it.

@janvorli janvorli merged commit a969c53 into dotnet:main Jul 22, 2022
@janvorli janvorli deleted the remove-cgroups-assert branch July 22, 2022 15:51
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix incorrect assert for cgroup file system type

6 participants