Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Details#72250 was about supporting the older llvm-toolchain. This PR is about supporting the older cmake version. Turned out cc @hoyosjs, @agocke, @janvorli, I opened this PR so it can be included in .NET 7 RC1. It also unblocked #71725, but that PR has some other (deref and nuget packaging related) issue, which might not make it in .NET 7.
|
hoyosjs
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#72250 was about supporting the older llvm-toolchain. This PR is about supporting the older cmake version. Turned out
NO_CACHEwas introduced in cmake 3.21 and some CI legs use the older version (I was testing it on 3.24).cc @hoyosjs, @agocke, @janvorli, I opened this PR so it can be included in .NET 7 RC1. It also unblocked #71725, but that PR has some other (deref and nuget packaging related) issue, which might not make it in .NET 7.