Analyze reaching PHI in GetRangeFromAssertions (more branch foldings) #123563
+191
−174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some interesting diffs are produced.
I slowly mimic what SSA-based GetRange does, but purely on top of VNs and assertions. This should be, in theory, more powerful, doesn't require a separate "does overflow" path, can be called from Global Assertion Prop general optimizations.
simple example: