[release/10.0] Update OpenSUSE container references to 16.0 and add test compatibility fixes #122373
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: richlander <2608468+richlander@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenSUSE container reference in Helix pipeline configuration from version 15.6 to 16.0 to align with current OpenSUSE releases. This is an infrastructure-only change for CI/CD testing pipelines.
Key changes:
- Updated Helix queue name and container image references from OpenSUSE 15.6 to 16.0
- Change applies to Linux x64 CoreCLR extra-platforms inner loop testing
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g Failures are related to macOS 13 deprecation and unrelated |
|
It looks like runtime-extra-platforms never ran so we don't ahve the required coverage. Kicking off again. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@richlander I am seeing you have ported the Japanese calendar breaking change here. I don't think this is right. If we need to service this change need to be approved by tactics. So far, I am not seeing any real user need it or blocked by this change to justify porting to servicing. I already submitted before in this PR the change ff082da which make the tests pass. |
|
Oh, got it. We can revert that part. Do you want to ask copilot to make the desired change? Sorry that I misinterpreted your earlier statement. That said, I have a memory (from yesterday; perhaps wrong) that a rebuild still demonstrated the calendar related failure. |
|
@copilot could you please revert the changes done in the files: JapaneseCalendar.cs, JapaneseCalendar.Icu.cs, JapaneseCalendarAddMonths.cs, and JapaneseCalendarTests.cs |
Let's see if we get any failure after reverting the changes and I can try to fix that. |
Reverted changes to Japanese calendar minimum date as this is a breaking change that should not be ported to servicing without approval. The test fix from commit ff082da is sufficient for OpenSUSE 16.0 compatibility. Files reverted: - JapaneseCalendar.cs - JapaneseCalendar.Icu.cs - JapaneseCalendarAddMonths.cs - JapaneseCalendarTests.cs Co-authored-by: tarekgh <10833894+tarekgh@users.noreply.github.com>
Done. Reverted the Japanese calendar changes in commit f19d642. The files have been restored to their original state (with the 1868/09/08 minimum date). The test fix from commit ff082da should be sufficient for OpenSUSE 16.0 compatibility without the breaking change. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tarekgh I see the Japanese Calendar failures. |
|
@richlander I have no idea why these failed calendar tests are listed under known test errors and pointing at #117164. Anyway, I'll try to take a look tomorrow and find out what is going on. |
…seCalendar min supported date
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
main PR #122371
Description
Updates OpenSUSE container version from 15.6 to 16.0 in Helix pipeline configuration for Linux x64 CoreCLR extra-platforms testing, and includes necessary test fixes to ensure compatibility with OpenSUSE 16.0.
Infrastructure Changes:
eng/pipelines/libraries/helix-queues-setup.yml: Updated queue name and container image fromopenSUSE.15.6toopenSUSE.16.0Test Compatibility Fixes (backported from main PR #122371):
Platform Detection: Added
IsOpenSUSE16property toPlatformDetection.Unix.csto detect OpenSUSE 16.0 and OpenSUSE Leap 16.0Networking Tests: Added
ActiveIssueattribute to skipPackage_Unsupported_NTLMtest on OpenSUSE 16, which ships with broken gss-ntlmssp 1.2 (similar to Ubuntu 24 and 26)Globalization Tests:
Note: Japanese calendar changes were intentionally excluded from this PR as they constitute a breaking change that requires servicing approval. The existing test fix from commit ff082da is sufficient for OpenSUSE 16.0 compatibility.
Customer Impact
None. Infrastructure-only change for CI/CD pipeline testing with test compatibility fixes to ensure test suite passes on the new platform.
Regression
No. This is a container version update to align with current OpenSUSE releases, with corresponding test fixes to handle platform-specific behavior differences.
Testing
CI/CD pipeline validation through runtime-extra-platforms workflow. Test fixes ensure that the existing test suite works correctly on OpenSUSE 16.0 by:
Risk
Low. Changes include:
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.