[release/9.0] Fix stack overflow in the configuration source gen #106668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
This was referenced Aug 20, 2024
Open
ericstj
approved these changes
Aug 21, 2024
jeffhandley
approved these changes
Aug 22, 2024
Member
jeffhandley
left a comment
There was a problem hiding this comment.
Approved for RC2. Reliability issue that we'd service for.
Member
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Member
|
Build had the failure due to ILC problem. Rerunning to ensure we get a complete build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106511 to release/9.0
/cc @ericstj @tarekgh
Customer Impact
When using the configuration source generator on a type that has a cycle in it's generic parameter the source generator will crash with a stack overflow, eg:
Regression
Testing
Validated customer reported type, unit tests added.
Risk
Low, only impacts users of source generator and only paths where we inspect element types.