Update MethodTable::IsDynamicStatics and DacpMethodTableData::bIsDynamic to return 0/1 instead of flag value

[elinor-fung]

MethodTable::IsDynamicStatics just gets the flag

runtime/src/coreclr/vm/methodtable.h

Lines 2570 to 2574 in c88c31b

	inline DWORD IsDynamicStatics()
	{
	LIMITED_METHOD_DAC_CONTRACT;
	return GetFlag(enum_flag_DynamicStatics);
	}

So if it is set, it returns the flag value (0x2)

DAC just sets DacpMethodTableData::bIsDynamic to MethodTable::IsDynamicStatics.

Change both to return TRUE/FALSE instead of the flag value. Per #106504 (comment), this was the behaviour until somewhat recently.

[dotnet-policy-service]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

[lambdageek]

@elinor-fung before eb8f54d MethodTable::IsDynamicStatics used to be:

   return !TestFlagWithMask(enum_flag_StaticsMask, enum_flag_StaticsMask_NonDynamic);

which is always 0 or 1 because of how ! works. So I think it's probably safe to update the runtime (and indirectly fix the value returned by the brittle DAC)

[elinor-fung]

I went with both - switching the runtime back to always return 0/1 and also switching the DAC to always return 0/1 (so it won't be affected by any inadvertent change in the value from the runtime).

[lambdageek]

I'm not sure whether this meets the bar for backports to RC1, but this now leaves net9.0 as the only runtime that returns non-0/1.

[hoyosjs]

It likely is OK for rc2. Easy enough to do a bar check.

[elinor-fung]

/backport to release/9.0

[github-actions]

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10457525842