Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 12, 2024

Backport of #104514 to release/8.0-staging

/cc @hoyosjs @mikelle-rogers

Customer Impact

Customers running on macOS x64 experience random crashes if the jitted code uses upper halves of the ymm registers. These halves were not being copied when a hardware exception occurred to the context used to handle the exception and were zeroed out when continuing after an exception.

Regression

  • Yes
  • No

Testing

Local directed testing

Risk

Low, the change adds previously missing data to the context

@ghost ghost added the area-PAL-coreclr label Jul 12, 2024
@janvorli janvorli modified the milestones: 9.0.0, 8.0.x Jul 12, 2024
@janvorli janvorli added the Servicing-consider Issue for next servicing release review label Jul 12, 2024
@janvorli janvorli self-requested a review July 12, 2024 18:49
@carlossanlop
Copy link
Contributor

Friendly reminder that Monday July 15th is Code Complete day, that's the deadline to get this included in the August Release.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 8.0.x

@mangod9
Copy link
Member

mangod9 commented Jul 12, 2024

Just realized there is an extra logging change in the backport. Is that expected?

@janvorli
Copy link
Member

Just realized there is an extra logging change in the backport. Is that expected?

Ah, no, that came from the original branch, I've missed it - it should not be there, let me remove it.

@janvorli janvorli force-pushed the backport/pr-104514-to-release/8.0-staging branch from aeaa2a1 to 1928ba4 Compare July 12, 2024 21:55
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 13, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 8.0.x, 8.0.8 Jul 13, 2024
@carlossanlop
Copy link
Contributor

@janvorli @mangod9 is this ready to merge? I'm about to flow staging into branch. If we want this fix included in the August release, please merge it.

@janvorli
Copy link
Member

is this ready to merge?

@carlossanlop yes, it is.

@janvorli janvorli merged commit c9edbb3 into release/8.0-staging Jul 15, 2024
@hoyosjs hoyosjs deleted the backport/pr-104514-to-release/8.0-staging branch July 17, 2024 17:22
@danny-zegel-zocdoc
Copy link

when is this expected to be released?

is there a way I can download the staging/beta version of the runtime in the mean time?

@mikelle-rogers
Copy link
Member

Hi @danny-zegel-zocdoc, this fix should be in .NET 9 preview 6. You can download that here: https://dotnet.microsoft.com/en-us/download/dotnet/9.0

@danny-zegel-zocdoc
Copy link

Hi @danny-zegel-zocdoc, this fix should be in .NET 9 preview 6. You can download that here: https://dotnet.microsoft.com/en-us/download/dotnet/9.0

i'm working in .NET 8, would like a .NET 8 runtime

@mikelle-rogers
Copy link
Member

The next .NET 8 update will be later this month.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants