Draft
Conversation
- Added new flaky test pipeline and plumbed it through the MDS core pipeline.
Contributor
There was a problem hiding this comment.
Pull request overview
Splits flaky test execution into a dedicated Azure DevOps pipeline and introduces a flakyTestsOnly switch to run either flaky-only or non-flaky-only test suites via the shared CI templates.
Changes:
- Added a new
CI-SqlClient-Flakypipeline YAML that runs only flaky tests onmain(CI + weekday schedule). - Plumbed a new
flakyTestsOnlyboolean parameter throughdotnet-sqlclient-ci-core.yml→ci-run-tests-stage.yml→ci-run-tests-job.yml→run-all-tests-step.yml. - Refactored the test-running step template to conditionally run flaky vs non-flaky test targets (and mark flaky runs
continueOnError).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/sqlclient/sqlclient-flaky-tests-pipeline.yml | New pipeline definition that extends the core template with flakyTestsOnly: true. |
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds flakyTestsOnly parameter and forwards it into the test stage template. |
| eng/pipelines/common/templates/steps/run-all-tests-step.yml | Adds conditional branching to run flaky-only vs non-flaky-only test tasks. |
| eng/pipelines/common/templates/stages/ci-run-tests-stage.yml | Accepts/forwards flakyTestsOnly into test jobs. |
| eng/pipelines/common/templates/jobs/ci-run-tests-job.yml | Accepts/forwards flakyTestsOnly into the test execution step template. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3936 +/- ##
===========================================
- Coverage 90.82% 67.55% -23.28%
===========================================
Files 6 263 +257
Lines 316 66198 +65882
===========================================
+ Hits 287 44718 +44431
- Misses 29 21480 +21451
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The flaky tests are preventing PR and CI pipeline runs from completing successfully. They don't add any confidence to those pipelines, so we will split them out into their own pipeline. This has many benefits:
Testing
NOTE: We won't be able to test the new Flaky Tests pipeline until this merges to main. The new YAML file must exist on main before Azure DevOps will allow us to create the new pipeline in the Public project.