Skip to content

Create separate flaky tests pipeline#3936

Draft
paulmedynski wants to merge 2 commits intomainfrom
dev/paul/flaky-pipeline
Draft

Create separate flaky tests pipeline#3936
paulmedynski wants to merge 2 commits intomainfrom
dev/paul/flaky-pipeline

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Feb 4, 2026

Description

The flaky tests are preventing PR and CI pipeline runs from completing successfully. They don't add any confidence to those pipelines, so we will split them out into their own pipeline. This has many benefits:

  • Avoid long-running flaky tests from timing out otherwise successful PR/CI runs.
  • Remove the spruious error/warning clutter from the Azure DevOps UIs.
  • Consolidate flakiness into its own pipeline we can observe as necessary.

Testing

  • The normal PR/CI runs will verify that the regular test runs are still functioning.
  • The new Flaky Test CI pipeline will verify the flaky tests.

NOTE: We won't be able to test the new Flaky Tests pipeline until this merges to main. The new YAML file must exist on main before Azure DevOps will allow us to create the new pipeline in the Public project.

- Added new flaky test pipeline and plumbed it through the MDS core pipeline.
Copilot AI review requested due to automatic review settings February 4, 2026 16:31
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Splits flaky test execution into a dedicated Azure DevOps pipeline and introduces a flakyTestsOnly switch to run either flaky-only or non-flaky-only test suites via the shared CI templates.

Changes:

  • Added a new CI-SqlClient-Flaky pipeline YAML that runs only flaky tests on main (CI + weekday schedule).
  • Plumbed a new flakyTestsOnly boolean parameter through dotnet-sqlclient-ci-core.ymlci-run-tests-stage.ymlci-run-tests-job.ymlrun-all-tests-step.yml.
  • Refactored the test-running step template to conditionally run flaky vs non-flaky test targets (and mark flaky runs continueOnError).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
eng/pipelines/sqlclient/sqlclient-flaky-tests-pipeline.yml New pipeline definition that extends the core template with flakyTestsOnly: true.
eng/pipelines/dotnet-sqlclient-ci-core.yml Adds flakyTestsOnly parameter and forwards it into the test stage template.
eng/pipelines/common/templates/steps/run-all-tests-step.yml Adds conditional branching to run flaky-only vs non-flaky-only test tasks.
eng/pipelines/common/templates/stages/ci-run-tests-stage.yml Accepts/forwards flakyTestsOnly into test jobs.
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Accepts/forwards flakyTestsOnly into the test execution step template.

@paulmedynski paulmedynski marked this pull request as ready for review February 4, 2026 16:49
@paulmedynski paulmedynski requested a review from a team as a code owner February 4, 2026 16:49
@paulmedynski paulmedynski marked this pull request as draft February 4, 2026 18:19
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.55%. Comparing base (a0357b2) to head (7ca6b0c).

❗ There is a different number of reports uploaded between BASE (a0357b2) and HEAD (7ca6b0c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a0357b2) HEAD (7ca6b0c)
addons 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3936       +/-   ##
===========================================
- Coverage   90.82%   67.55%   -23.28%     
===========================================
  Files           6      263      +257     
  Lines         316    66198    +65882     
===========================================
+ Hits          287    44718    +44431     
- Misses         29    21480    +21451     
Flag Coverage Δ
addons ?
netcore 67.63% <ø> (?)
netfx 66.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant