Complete removal of SQL 2000 support#3217
Conversation
…helZ/SqlClient into pr/tdsparser-remove-sql-2000
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionSmi.cs
Show resolved
Hide resolved
paulmedynski
left a comment
There was a problem hiding this comment.
Looks good - one small change requested.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
| } | ||
| finally | ||
| { | ||
| if (con != null) |
There was a problem hiding this comment.
Can you add braces here, or use null-conditional con?.Dispose() ?
There was a problem hiding this comment.
Yes - fixed. I've updated the netcore code to keep it in sync.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
- Coverage 72.58% 66.14% -6.44%
==========================================
Files 289 282 -7
Lines 59503 59203 -300
==========================================
- Hits 43188 39162 -4026
- Misses 16315 20041 +3726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This finishes the work from #3206 and prior PRs. It removes the
Is2005OrNewerandIs2000properties fromSqlCommand,SqlConnection,SqlInternalConnectionSmi,SqlInternalConnectionTds,SqlInternalConnectionandTdsParser, then chases those references through the codebase.I'd appreciate a CI run against this, although I don't think there'll be any surprises here - all of these code paths should be dead.