Merge | Cleanup Pre 2005 Support in TdsParser#3085
Merge | Cleanup Pre 2005 Support in TdsParser#3085MichelZ wants to merge 6 commits intodotnet:mainfrom
Conversation
…helZ/SqlClient into pr/tdsparser-remove-sql-2000
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3085 +/- ##
==========================================
+ Coverage 72.74% 72.75% +0.01%
==========================================
Files 283 283
Lines 58968 58883 -85
==========================================
- Hits 42894 42839 -55
+ Misses 16074 16044 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks good to me. Once this PR's merged, I've got a branch ready to submit (diff - about half the size of this PR) which chases the references to |
paulmedynski
left a comment
There was a problem hiding this comment.
I love seeing old code get removed!
| private bool _is2000SP1 = false; // set to true if speaking to 2000 SP1 or later | ||
|
|
||
| private bool _is2005 = false; // set to true if speaking to 2005 or later | ||
| private bool _is2005 = false; |
There was a problem hiding this comment.
I think we should remove this field entirely.
|
Meant to close this in favor of #3206 |
Now that #2839 is merged, the Pre 2005 Code can be removed from netfx to align netfx & netcore code for future merge of TdsParser.
It also removes asserts that were used to gate 2005-only code
The code does not aim to remove Pre 2005 Code from other classes
This is working towards #2953