Align whole comments between netfx and netcore

[MichelZ]

All this PR does is deal with comments, so hopefully easy to review
Mostly removes obsolete comments from netfx to align netfx and netcore for later mering

Part of #2953

[benrr101]

To be honest I'm not sure about this one. I appreciate the efforts to make merging this class easier, but I'm also concerned about losing in-code documentation.

Questions for other reviewers:

• Are these TODOs actually done?
• What does tagging something as UNDONE actually mean?
• Is there any benefit to keeping old ticket IDs? I personally wouldn't even know where to go looking for them.

Would appreciate review from @ErikEJ or @Wraith2 before I approve

[MichelZ]

I‘m also happy to switch it around to add the info on the other side, if that‘s the concern.

AFAIK these things were removed on the netcore side before for a reason I guess

[ErikEJ]

I vote for keeping them for the purpose of merging.

[benrr101]

@ErikEJ Sorry, I'm a bit confused with that answer. Are you saying "leave the old ticket IDs until merging is completed then remove them", "leave old ticket IDs indefinitely", or something else?

Also what does UNDONE mean in these contexts? @cheenamalhotra @saurabh500

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ErikEJ]

@benrr101 postpone the decision to remove them (or not) ...

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.43%. Comparing base (4bc9ee6) to head (9f984ce).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	57.14%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   72.50%   72.43%   -0.07%     
==========================================
  Files         288      288              
  Lines       59529    60229     +700     
==========================================
+ Hits        43159    43629     +470     
- Misses      16370    16600     +230     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	75.38% <100.00%> (-0.06%)	⬇️
netfx	70.93% <57.14%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benrr101]

As per the suggestion from @ErikEJ, let's retain the old ticket information and todo/undone tags. I think that more/less amounts to copying them from netfx to netcore. Although I personally like removing stuff, I don't want to lose any history if possible.

Thanks for your patience on this one 👍

[MichelZ]

OK, no worries. Will adjust

[MichelZ]

@benrr101 Done

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).