fix(edit-field): Replace jQuery with direct DOM manipulation #34329
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bnail and multiselect updates
…o-persist-when-jquery-is-included-via-custom-field-vtl
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request partially addresses issue #34288 by replacing jQuery-conflicting $() selectors with standard document.getElementById() calls in field update functions. The issue occurs when external jQuery is loaded via a Custom Field VTL script, overriding the legacy $() shorthand function and breaking field persistence for checkboxes and date fields.
Changes:
- Replaced
$()withdocument.getElementById()in checkbox, multi-select, and image thumbnail update functions
…hen-jquery-is-included-via-custom-field-vtl' of github.com:dotCMS/core into 34288-defect-checkbox-and-date-fields-fail-to-persist-when-jquery-is-included-via-custom-field-vtl
hmoreras
approved these changes
Jan 16, 2026
adrianjm-dotCMS
approved these changes
Jan 16, 2026
oidacra
approved these changes
Jan 16, 2026
dario-daza
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way DOM elements are selected in the
edit_field.jspfile, replacing the use of the$()selector (which is likely a jQuery-style or custom selector) with the native JavaScriptdocument.getElementByIdmethod. This change improves code clarity and performance by relying on standard, modern JavaScript APIs.Refactoring DOM element selection:
$()selector withdocument.getElementByIdfor updating the image thumbnail source in thechange<%=field.getFieldContentlet()%>ThumbnailSizefunction.update<%=field.getVelocityVarName()%>MultiSelectfunction to usedocument.getElementByIdinstead of$()for accessing the multi-select element and its hidden field. [1] [2]document.getElementByIdinstead of$().This PR fixes: #34288
This PR fixes: #34288