image/tree: Don't limit name width if non tty#6656
Merged
thaJeztah merged 2 commits intodocker:masterfrom Nov 13, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
14c6598 to
dc0e57f
Compare
dc0e57f to
f9f612d
Compare
robmry
reviewed
Nov 13, 2025
Contributor
robmry
left a comment
There was a problem hiding this comment.
Looks good, except for ...
Previously when no terminal was attached the width was assumed to be 80. This is too short for most image names which truncated the names when output was redirect (for example to `grep`). This disabled the name truncation if the terminal width can't be determined. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
f9f612d to
ed281dd
Compare
robmry
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when no terminal was attached the width was assumed to be 80.
This is too short for most image names which truncated the names when output was redirect (for example to
grep).This disabled the name truncation if the terminal width can't be determined.