cli/config/types: remove deprecated AuthConfig.Email field#6515
Merged
austinvazquez merged 1 commit intodocker:masterfrom Sep 29, 2025
Merged
cli/config/types: remove deprecated AuthConfig.Email field#6515austinvazquez merged 1 commit intodocker:masterfrom
austinvazquez merged 1 commit intodocker:masterfrom
Conversation
Member
Author
|
Ah! Looks like we cut some corners and did a direct convert of the type, not mapping each field; |
96ff52e to
bee8ca4
Compare
bee8ca4 to
662c143
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
662c143 to
4bbd807
Compare
Relates to [cli@27b2797], which forked this type from the Moby API, and [cli@aab947d], which fixed the deprecation comment. This field is no longer used since Docker 1.11 (API version 1.23) through [moby@aee260d] and [engine-api@9a9e468], and the fix of the deprecation comment was included in the 28.4.0 release. This patch removes the field. [cli@27b2797]: docker@27b2797 [cli@aab947d]: docker@aab947d [moby@aee260d]: moby/moby@aee260d [engine-api@9a9e468]: docker-archive-public/docker.engine-api@9a9e468 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
4bbd807 to
e9664b9
Compare
austinvazquez
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
Relates to cli@27b2797, which forked this type from the Moby API, and cli@aab947d, which fixed the deprecation comment.
This field is no longer used since Docker 1.11 (API version 1.23) through moby@aee260d and engine-api@9a9e468, and the fix of the deprecation comment was included in the 28.4.0 release.
This patch removes the field.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)